Skip to content

Remove indent in JSX#543

Merged
chvmvd merged 1 commit into
masterfrom
remove-indent-in-jsx
Nov 5, 2023
Merged

Remove indent in JSX#543
chvmvd merged 1 commit into
masterfrom
remove-indent-in-jsx

Conversation

@chvmvd
Copy link
Copy Markdown
Contributor

@chvmvd chvmvd commented Nov 4, 2023

MDX v3になったことにより、JSX内でのMarkdownのインデントが不要になり、前後の空行も不要になったので削除 #531

@chvmvd chvmvd mentioned this pull request Nov 4, 2023
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6041ad8
Status: ✅  Deploy successful!
Preview URL: https://3ae350f0.utcode-learn.pages.dev
Branch Preview URL: https://remove-indent-in-jsx.utcode-learn.pages.dev

View logs

@chvmvd chvmvd requested review from aster-void and chelproc November 4, 2023 16:10
@aster-void
Copy link
Copy Markdown
Contributor

むしろインデントが増えてるような..?

Base automatically changed from migrate-to-docusaurus-3 to master November 5, 2023 05:35
@chvmvd
Copy link
Copy Markdown
Contributor Author

chvmvd commented Nov 5, 2023

むしろインデントが増えてるような..?

それが正しい感じです。MDX v1では、インデントを入れるとうまくパースされませんでしたが、MDX v3からはインデントを入れても正しくパースされるようになりました!

Copy link
Copy Markdown
Contributor

@aster-void aster-void left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いいと思います!

@chvmvd chvmvd merged commit 068cdd0 into master Nov 5, 2023
@chvmvd chvmvd deleted the remove-indent-in-jsx branch November 5, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants